Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery ids other than 0 or 1? #72

Closed
scnale opened this issue Sep 16, 2022 · 1 comment
Closed

Recovery ids other than 0 or 1? #72

scnale opened this issue Sep 16, 2022 · 1 comment

Comments

@scnale
Copy link

scnale commented Sep 16, 2022

Hey, I was wondering if recovery IDs for ECDSA signatures other than 0 or 1 are supported. Here, the recovery id is restricted to 0 or 1. However, the signing logic can generate recovery IDs 2 and 3 as I understand here. Is there something I am missing in how these would be treated?

From what little I've read, these other IDs are quite rare. I don't know if there are any readily available tests for these cases.

@paulmillr
Copy link
Owner

paulmillr commented Sep 17, 2022

I think 2/3 only possible for CURVE.n <= r < CURVE.p, which almost never happens.

It would be good to support it, but it's not a huge concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants