Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload issues with a larger project #36

Closed
gilesknap opened this issue Dec 2, 2022 · 17 comments
Closed

Upload issues with a larger project #36

gilesknap opened this issue Dec 2, 2022 · 17 comments
Labels
bug Something isn't working

Comments

@gilesknap
Copy link

What are the steps to reproduce this issue?

  1. clone git@github.com:gilesknap/pico-xmas.git
  2. launch the folder in vscode
  3. connect a pico
  4. Command Pallette Pico-w-Go->Delete all files from board
  5. right click Pico-w-Go->Upload project from file Explorer

What happens?

The files start to upload but after one or two the process stalls
sending a soft reset via the command pallette makes the upload move on to the next file
If this process is repeated a few times and the timing is right then the project does download OK.
If I don't do the soft reset then we see Upload failed.timeout.

The output in the Terminal looks like this

>>> 
Uploading project (main folder)...

Not safe booting, disabled in settings
Uploading to / ...
Reading file status
Creating dir morse
Creating dir utils
[1/6] Writing file '01_start_morse.py' (271 bytes)
[2/6] Writing file '02_count.py' (1 kB)
[3/6] Writing file 'LICENSE' (11 kB)
[4/6] Writing file 'morse/morse_code.py' (1 kB)

What were you expecting to happen?

All project files should upload with no additional intervention.
Thonny is able to upload this without issue.

Any logs, error output, etc?

(To get extension logs see Terminal > Output > Protcoll (Extensionhost) and copy output concerning picowgo)
(If it’s long, please paste to https://gist.github.com and insert the link here)

Any other comments?

Nice project !

Support info

I'm using a pico H not a pico W - does that make a difference?

Version: 1.73.1
Commit: 6261075646f055b99068d3688932416f2346dd3b
Date: 2022-11-09T03:54:53.913Z
Electron: 19.0.17
Chromium: 102.0.5005.167
Node.js: 16.14.2
V8: 10.2.154.15-electron.0
OS: Linux x64 5.15.0-56-generic
Sandboxed: No
@gilesknap gilesknap added the bug Something isn't working label Dec 2, 2022
@gilesknap gilesknap mentioned this issue Dec 4, 2022
Closed
@vifeng
Copy link

vifeng commented Dec 8, 2022

same error I have a pico H.
VSCODE : Version: 1.74.0
Python 3.11.1
all latest extensions
Mac os Monterey 12.6.1

@magabriel
Copy link

This bug started to bite me hard just a few days ago, while the "Upload project" command started to fail at random and finally stopped working at all. This behavior seems related to either the number of files or its size because it was getting worse fast as my project grew in size.
So now I have to upload the whole project with Thonny and then upload the file I'm working on separately. Far from ideal, more so because the FTP server never worked for me either.

@gavinbaker999
Copy link

gavinbaker999 commented Dec 17, 2022 via email

@phasiclabs
Copy link

phasiclabs commented Jan 21, 2023 •
edited
Loading

I'm having similar trouble on a Pico W with 24 files in the project.

I have a magic ritual I have to follow to get my changes to upload to the board - whenever I make changes, I have to delete all files from the board, unplug it re-plug it in, upload 1 file only, unplug/replug, modify a file, then finally upload the project.

If I don't do this, it will either freeze mid upload, decide there is nothing to upload, or sometimes it removes existing files from the board.

It seems like there is some kind of caching going on that is not working - even with all files deleted from the board, it won't upload my project unless I make new modifications.

Windows 10, VS Code 1.74.3, MicroPython v1.19.1

@bmurphy1976
Copy link

bmurphy1976 commented Jan 22, 2023 •
edited
Loading

@phasiclabs oof that's a lot. Have you tried using rshell instead? I've found both Pico-W-Go and ampy to be very unreliable. My current workflow is to us Pico-W-Go to help with auto completion but leave it disconnected. I'm then using rshell on the command line to upload, sync, and run files.

@gavinbaker999
Copy link

gavinbaker999 commented Jan 22, 2023 via email

@phasiclabs
Copy link

@bmurphy1976 it's only just started happening to me now I'm working on a larger project, so I've not looked for other workarounds yet.
I'm starting to think modifications to main.py make things worse - the project upload fails 100% if that is modified - possibly it's locked by the board? It still fails very often with other files though.
I'll check out rshell though - thanks for the tip.

@paulober
Copy link
Owner

paulober commented Jan 30, 2023 •
edited
Loading

@gilesknap I tryed reporducing your issue by uploading the repo you mentioned to my pico (with PicoWGo). But its all working fine, i got no errors, nothing. All files get uploaded like they should.

Can you confirm this issue still exists for you?

@paulober
Copy link
Owner

paulober commented Jan 30, 2023 •
edited
Loading

@phasiclabs Do you have a sample project for me to reproduce this error?
Tried it with a project containing more than 35 files, no issues.

@gilesknap
Copy link
Author

@paulober I'll give this another go this evening.

@paulober
Copy link
Owner

paulober commented Feb 3, 2023

@paulober I'll give this another go this evening.

Can I mark this as resolved?

@gilesknap
Copy link
Author

Sorry for the delay.

I tried this again and am still seeing the issue. I note that if I do a 'delete all files on the board' followed by upload it always hangs on the same file as shown below.


>>> 
Uploading project (main folder)...

Not safe booting, disabled in settings
Uploading to / ...
Reading file status
Creating dir hardware
Creating dir morse
Creating dir music
Creating dir utils
[1/16] Writing file 'LICENSE' (11 kB)
[2/16] Writing file 'd01_start_morse.py' (292 bytes)
[3/16] Writing file 'd02_count.py' (498 bytes)
[4/16] Writing file 'd03_buttons.py' (497 bytes)
[5/16] Writing file 'd04_controller.py' (3 kB)
[6/16] Writing file 'd05_music.py' (143 bytes)
[7/16] Writing file 'd06_photo_t.py' (1 kB)
[8/16] Writing file 'd07_pir.py' (1 kB)
[9/16] Writing file 'hardware/advent.py' (1 kB)
[10/16] Writing file 'morse/morse_code.py' (1 kB)

The project that exhibits this issue is here https://github.com/gilesknap/pico-xmas
I'm on ubuntu 22.04

@paulober
Copy link
Owner

paulober commented Apr 11, 2023 •
edited
Loading

@gilesknap, @magabriel, @bmurphy1976 V3 is here, completely rewritten from ground up, so i wanted to ask you if this issue is fixed by the new release?

@gilesknap
Copy link
Author

gilesknap commented Apr 12, 2023 via email

@gilesknap
Copy link
Author

OK this looks good. I had no issues with project upload with the same set of files. Thanks for the fix!

A couple of minor things I noticed:

  • I was a little bemused that the REPL did not appear by default and I had to click on the + in the terminal. Maybe this is Connecting a Pico W doesn't trigger a vREPL #60?
  • Also there is now no logging when uploading files / projects, just a pop up notification while it is happening. That initially threw me as I did not believe that it was working. I'm pretty OK with this is if project upload is rock solid - so just an observation.

@paulober
Copy link
Owner

@gilesknap I'm glad to here that the issue is resolved for you by the new version.
As for the other things you mentioned:

  • If you want the vREPl auto open you can set the picowgo.openOnStart settings like documented in the README.md
  • I also thought about printing the upload status of each file into the vREPL, as for now i decided to use the integrated progress bar notification type to not remove stuff already typed into the vREPL by the user but not submitted. But maybe i'll make the progress notification have a growing progress indicator and if something fails print out the file and progress where it stops into the vREPL.

@gilesknap
Copy link
Author

Thanks Paul.

  • But maybe i'll make the progress notification have a growing progress indicator and if something fails print out the file and progress where it stops into the vREPL.

That would be ideal

@paulober paulober mentioned this issue Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@bmurphy1976 @phasiclabs @magabriel @gilesknap @gavinbaker999 @vifeng @paulober