Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY the CacheString #5

Closed
Wicpar opened this issue Dec 9, 2022 · 2 comments
Closed

DRY the CacheString #5

Wicpar opened this issue Dec 9, 2022 · 2 comments

Comments

@Wicpar
Copy link
Contributor

Wicpar commented Dec 9, 2022

there is a lot of redundant code in the CacheString

we could use delegate to do some of that, or other means.

@paulocsanz
Copy link
Owner

I was able to remove most implementations for CacheString on main because of Deref and DerefMut provided for it based on ArrayString.

Sadly functions that return Self or trait implementations can't be done, but honestly now the overlap is so small that I'm ok with it. I'm still open to changing that, but closing this for now as things have changed a lot.

I'm not eager to use a lot of syntax magic to avoid this small problem but I'm open to it provided you can show me a reasonable approach

@Wicpar
Copy link
Contributor Author

Wicpar commented Dec 25, 2022

yes it looks quite reasonable now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants