Feat/list pagination #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
conflicts |
Resolved |
|
@paulodiovani can you please merge my last two pull requests before midnight |
|
@kamaladenalhomsi Can't promise, |
nolleto
reviewed
Oct 31, 2019
| <div class="pr-list"> | ||
| <div | ||
| v-for="(user, userIndex) in users" | ||
| v-bind:key="user.username" | ||
| v-bind:key="userIndex" |
There was a problem hiding this comment.
There is a reason for using the index here instead of username?
Because this can cause bug since Vue will use it to render or not again the item in the list.
For example, if I'm rendering a list of texts with the array ['apple', 'banana', 'pineapple']
- apple (key: 0)
- banana (key: 1)
- pineapple (key: 2)
and I change it to ['apple', 'pineapple'] the second item will render banana since the key is the same.
- apple (key: 0)
- banana (key: 1)
;)
|
Closed for lack of updates, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add pagination (infinite scroll) for the pull requests list, and also make PRs expand when hovering