Added support for Take and Paginate, also removed += #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PaulCheng and @sakash279 , can one of you please take a look at this? |
PaulCheng
reviewed
Sep 17, 2020
| ) | ||
| # Internal function | ||
| # Executes query in async mode | ||
|
|
||
| if ($TableQuery -ne $null) | ||
| { | ||
| $token = $null | ||
| $AllRows = @() | ||
| do | ||
| if ($Paginate) |
There was a problem hiding this comment.
The general guideline is to always use continuation token while invoking Segmented Query, and it's recommended to always use Segmented Query.
The reason is when server (both storage and cosmosdb) clusters data into multiple physical partitions, the first page may contain no results but a continuation token.
I don't think we need this change, and I don't see any benefit of doing this change either. User may get confused what value to give to the Paginate parameter and ends up using true anyways.
|
As per current maintainers of the SDK recommendation we're closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I want to retrieve just 1 record from a table based on how they are sorted, so I implemented the Take parameter of the TableQuery and added the option to disable pagination so it only retrieves the first page of items.
Also, the += operator is quite slow when dealing with large arrays, so I reworked that section as well so it just outputs instead of storing the data to a variable and then outputting.