Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete last entry of a logbook #33

Merged
merged 24 commits into from
Jul 21, 2022

Conversation

abulgher
Copy link
Contributor

@abulgher abulgher commented Jul 5, 2022

The _validate_response was failing when deleting the last entry of a
logbook because it wasn't able to get the msg_id from the response
location path splitting.

Enclosed the clause in a try/except block and catching the ValueError.

abulgher and others added 24 commits July 2, 2022 10:13
Added the standard workflow for building a python app
Added the build package section
…ST.is since the readme file should be now included automatically.
First attempt to have the package published
In this way twine is not complaining about Markdown formatting
elog already exists in PyPI. Changed to py_elog.
The _validate_response was failing when deleting the last entry of a
logbook because it wasn't able to get the msg_id from the response
location path splitting.

Enclosed the clause in a try/except block and catching the ValueError.
@abulgher abulgher changed the title Delete last Delete last entry of a logbook Jul 5, 2022
@simongregorebner simongregorebner merged commit 3dd5864 into paulscherrerinstitute:master Jul 21, 2022
@abulgher abulgher deleted the delete_last branch December 8, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants