Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap foreignLayerStyles and foreignTextStyles overrides between libraries #4

Closed
yceballost opened this issue Nov 26, 2018 · 7 comments
Closed

Swap foreignLayerStyles and foreignTextStyles overrides between libraries #4

yceballost opened this issue Nov 26, 2018 · 7 comments
Assignees
@Pausansol
Labels
enhancement New feature or request

Comments

@yceballost
Copy link

Hi!

It's would be nice the possibility to connect text & layer styles from other libraries in symbols override.

By the moment, when I try to update the name of a style, (Ex: Style_1 to Style_2) the plugin can't identify the change and my workflow breaks.

Anyway, great job!!
Thanks!!
@yceballost yceballost changed the title Use styles from other libraries Use styles from others libraries Nov 26, 2018
@Pausansol Pausansol changed the title Use styles from others libraries Swap styles in overrides from others libraries Nov 26, 2018
@Pausansol Pausansol added the enhancement New feature or request label Nov 26, 2018
@Pausansol Pausansol changed the title Swap styles in overrides from others libraries Swap layer and text styles overrides between libraries Nov 26, 2018
@Pausansol
Copy link
Owner

Hi @yceballost, we realized this is a must for our plugin and we are currently developing this feature.

Thanks for the feedback

@Pausansol Pausansol self-assigned this Nov 26, 2018
@Pausansol Pausansol changed the title Swap layer and text styles overrides between libraries Swap foreignLayer and foreignTextStyles overrides between libraries Nov 26, 2018
@Pausansol Pausansol changed the title Swap foreignLayer and foreignTextStyles overrides between libraries Swap foreignLayerStyles and foreignTextStyles overrides between libraries Nov 26, 2018
@jonmh85
Copy link

jonmh85 commented Dec 6, 2018

This feature would be so useful! I have been looking for this since sketch added styles to libraries.

At the moment I work on a master file and then place the full templates as library symbols in a separate file for each brand/theme. Changing the the style overrides individually is a nightmare. This would be a life saver.

@Pausansol
Copy link
Owner

Hi @jonmh85, I'm glad to know that it will be useful for more people. You will like to know that we are working on it and we will make a release with this functionality before EOY.

@Pausansol Pausansol added this to the 2.0 milestone Dec 6, 2018
@Reac89
Copy link

Reac89 commented Dec 13, 2018

thanks @Pausansol for this beautiful plugin! The recent trend around libraries is to split them into multiple Sketch files so it would be perfect if your plugin could work with nested libraries!!

@Pausansol
Copy link
Owner

@Reac89 thanks for the feedback. This feature is currently in review.

Cheers

@Pausansol Pausansol removed this from the 2.0 milestone Dec 17, 2018
@Pausansol
Copy link
Owner

Issue closed, plugin version released with this new killer feature ;)

Cheers,
Pablo

@pterisaur
Copy link

This feature doesn't seem to be working anymore — style overrides in symbols are no longer replaced.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pausansol Pausansol

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Pausansol @yceballost @pterisaur @jonmh85 @Reac89