Race condition between spinner thread and write()

[sebageek]

When I use write() a lot on a spinner it often happens to me that the written text is displayed after the spinner message, like this:

[...]
noot noot
⠋ spinning...noot noot
noot noot
[...]

I used the script below to recreate the problem. It takes some time (400-800 writes) with it, but happens to me far more often with real world applications.

import random
import time

import yaspin

with yaspin.yaspin() as sp:
    sp.text = 'spinning...'
    while True:
        sp.write('noot noot')
        time.sleep(0.051 + random.randint(0, 10) / 100)

I think this happens because of concurrent access to sys.stdout.write() by the spinning thread and the spinners write(). This should be solvable by using a threading.Lock() and guarding access to sys.stdout.write() with it. In a quick local hack-fix-test it worked for me by doing this in write() and _spin(), but there are a lot more functions that would need guarding, if done right.

[pavdmyt]

Hi @sebageek

Thanks for reporting the issue! I'll take a look at it closer soon.
Please feel free to open PR.

[pavdmyt]

FIxed by #35 in yaspin v0.14.3.

Thanks @sebageek for contribution 🎉