Add hidden() to hide spinner in with-block #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sebageek Thanks for PR! I'll review it as soon as possible (probably this weekend). Also, check CI status here (it is disappeared from PR for unknown reasons): https://travis-ci.org/github/pavdmyt/yaspin/builds/715132078 |
pavdmyt
requested changes
Aug 9, 2020
With hidden() the spinner can be hidden in a with-block. This allows us
to write the following code:
sp.hide()
call_cli_menu()
sp.unhide()
as follows:
with sp.hidden():
call_cli_menu()
hidden() can be nested, therefore the following works:
with sp.hidden():
# generating some output
...
with sp.hidden():
# generating more output
...
sebageek
force-pushed
the
add-hidden-context-manager
branch
from
290d4ef
to
8256e4c
Compare
pavdmyt
approved these changes
Aug 13, 2020
|
@sebageek will include this feature into the next release. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With hidden() the spinner can be hidden in a with-block. This allows us
to write the following code:
as follows:
hidden() can be nested, therefore the following works: