Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-93888 | master #343

Closed
wants to merge 185 commits into from
Closed

Conversation

kyle-miho
Copy link

@kyle-miho kyle-miho commented Apr 12, 2019

adolfopa and others added 30 commits April 11, 2019 10:08
https://issues.liferay.com/browse/LPS-89371

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
…tion

https://issues.liferay.com/browse/LPS-90614

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
https://issues.liferay.com/browse/LPS-90614

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
…ementation

https://issues.liferay.com/browse/LPS-90614

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
… from implementation

https://issues.liferay.com/browse/LPS-90614

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
patriciajeanperez and others added 25 commits April 11, 2019 12:34
https://issues.liferay.com/browse/LPS-89371

Co-authored-by: weicao <wade.cao@liferay.com>
Co-authored-by: André de Oliveira <andre.oliveira@liferay.com>
… distinguish bootstrap dropdowns from clay ones
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@kyle-miho
Copy link
Author

liferay@946fd77
Hey Pavel, this is a fix for: LayoutPageTemplateEntryServiceTest.testAddLayoutPageTemplateEntryWithFragmentEntries
due to the commit above. I had our call to get the fragment entry links use the classNameId/classPK of layout associated with the created layoutPageTemplateEntry due to the change.

@pavel-savinov
Copy link
Owner

Just started reviewing :)

@pavel-savinov
Copy link
Owner

Pull request submitted to brianchandotcom#71448.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet