Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: doubleTapGesture must depend on pinchEnabled #54

Merged
merged 3 commits into from
Dec 9, 2023

Conversation

baronha
Copy link
Contributor

@baronha baronha commented Dec 7, 2023

I think when pinchEnable === false => doubleTap for zooming should also be disabled. Or is there an alternative prop to turn this off?
In my case, there is an Video Item and I don't want the user to be able to zoom into my

@pavelbabenko
Copy link
Owner

Hey @baronha
Good catch! But it's better to introduce new prop doubleTapEnabled
Will you be able to add it?

@baronha
Copy link
Contributor Author

baronha commented Dec 7, 2023

Hey @baronha Good catch! But it's better to introduce new prop doubleTapEnabled Will you be able to add it?

Sure. I'll add it and will send the PR back to you

@baronha
Copy link
Contributor Author

baronha commented Dec 8, 2023

@pavelbabenko I added doubleTapEnabled. Please review my code before merging

example/src/screens/Photos.tsx Outdated Show resolved Hide resolved
@pavelbabenko
Copy link
Owner

@baronha 1 small change and I'll merge it

@pavelbabenko pavelbabenko merged commit efb8b96 into pavelbabenko:main Dec 9, 2023
@pavelbabenko
Copy link
Owner

@baronha released in https://github.com/pavelbabenko/react-native-awesome-gallery/releases/tag/v0.3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants