Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to record program again with the TVBrowser TsrPlugin if the recording was deleted in TSR #62

Closed
cjaone opened this issue Feb 18, 2023 · 4 comments
Assignees

Comments

@cjaone
Copy link

cjaone commented Feb 18, 2023

Perform the following steps:

  1. Create recording with the TVBrowser TsrPlugin
  2. Later, while using TSR, you decide against the recording and delete it on the "records" page in TSR
  3. Later, you decide again to schedule the same recording with TVBrowser

Observed:

  • This program can never be recorded again with the TVBrowser.
  • A popup window with an error message appears.
  • In TVBrowser the TsrPlugin icon is still visible (TVBrowser thinks there is a recording), even after TVBrowser restart.

Possible solution:

  • The deletetvb function in TSR could always return "true", even if the recording is not present in TSR.
@Pavion
Copy link
Owner

Pavion commented Feb 19, 2023

Hi @cjaone!
This is a best issue description I've ever had! Sadly, I can't reproduce it...

I've followed your steps 1-3 and it's true that the icon in TVB stays then as there is no continuous synchronization. It's also true that you can't stop or "rerecord" the recording from TVB anymore.

Restarting TVB should (and have) fix this issue as nothing is persisted within TVB and the whole list is being synchronized upon TVB start!

This is a somewhat intended behavior, as I prefer to show an error message and allow user to resolve a potential error / conflict by restarting TVB instead of always sending true and hoping it would work out.

There must be an another cause for your issue. Could you please retrace your steps again?

Pavion referenced this issue in Pavion/TsrPlugin Feb 19, 2023
@Pavion
Copy link
Owner

Pavion commented Feb 19, 2023

Instead of always sending true I've made an another change in the plugin (see above).
If false is received, an TVB user now have the choice to force delete the entry (or not, which was the default behavior so far).
This change will be included in further plugin releases.

@cjaone
Copy link
Author

cjaone commented Feb 19, 2023

Hi Pavion, thank you. :-) Maybe I'll report more issues (and/or pull requests) in the future. I like the low entry barrier of TSR and that it's written in Python (I'm not running it on Synology, just on a small Linux homeserver).

You're right, after TVBrowser restart the icon is gone and recording is possible again. I just retested it again but yesterday it was different, very strange. Maybe I did a mistake.

Anyway, a change in TsrPlugin is even better. Thank you for implementing it!

@Pavion
Copy link
Owner

Pavion commented Feb 19, 2023

You're welcome to submit further issues or improvements, although I can't always guarantee a swift response.
See you!

@Pavion Pavion closed this as completed Feb 19, 2023
@Pavion Pavion self-assigned this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants