Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Language #60

Open
laischaves opened this issue Jan 26, 2021 · 22 comments
Open

New Language #60

laischaves opened this issue Jan 26, 2021 · 22 comments
Labels
enhancement New feature or request

Comments

@laischaves
Copy link

Can we add a BR Portuguese translation? I could work on it!

@laischaves laischaves added the enhancement New feature or request label Jan 26, 2021
@pavlobu
Copy link
Owner

pavlobu commented Jan 26, 2021

Hi @laischaves ,sure you can help with translation!
I'm a bit busy these days handling other stuff coming. If you are comfortable with git,
I will create a separate branch for you so you can get started with translations to Portuguese.

I have added i18n already, just need to make it more friendly for contributors.
I'll get back to you when it is ready!
Cheers,Paul

@pavlobu
Copy link
Owner

pavlobu commented Jan 26, 2021

Hi @laischaves ,

I wanted to ask you one thing.
Are you willing to also help with translations for a website?
Because I was thinking there is no point to add translations to app if website is not translated.

All best,
Paul

@laischaves
Copy link
Author

Hello @pavlobu,

Yes, I think it's really necessary and would like to help :)

@pavlobu
Copy link
Owner

pavlobu commented Jan 26, 2021

Great news! Ok then, ill need to get things ready on website as well too, coz right now it doesn't have i18n package integration yet. I'll update you on that.

Thank you!

@schiappa
Copy link
Contributor

Hi, @pavlobu ,

First of all, congratulations on the development of Deskreen!

Secondly, I offer myself to collaborate with the translations into Spanish of both the web and the app, if it helps.
Just let me know!

Cheers! 😊

@pavlobu
Copy link
Owner

pavlobu commented Jan 30, 2021

@schiappa Hi ! 👋 Thank you for liking it and using Deskreen! That is really great news! Your help is really encouraged and I'll need it soon. I'll let you know when preparations for translators are done in this thread. Will be doing it in early February. Keep in touch

Cheers,
Paul

@taotieren
Copy link
Contributor

taotieren commented Feb 11, 2021

I can add simplified Chinese translation(zh
_CN).

@pavlobu
Copy link
Owner

pavlobu commented Feb 11, 2021

Hi @taotieren @schiappa @laischaves,
I finished with adding all necessary translations templates for the current app version as well as some upcoming features translations too.
You can get started with translations here:
https://github.com/pavlobu/deskreen#get-started-for-translators

Currently there is no guidance for adding translations for a website, but I will be adding it really soon and I will update you on that.For now, you can start with app translations if you want
The instructions are friendly both for coders and non-coders.

Looking forward for your input,
Paul

@pavlobu
Copy link
Owner

pavlobu commented Feb 20, 2021

Hi @taotieren @schiappa @laischaves,

I finally finished language templates for Deskreen website.

Here are the guides on how to add a new language for Deskreen Website
https://github.com/Deskreen/deskreen-website-locales

Thank you in advance!
Paul

@schiappa
Copy link
Contributor

Hi Paul,

I've already made the PR to add the Spanish translations to the Deskreen website (Deskreen/deskreen-website-locales#3). I'll be working on the app translations into Spanish and try to commit that ASAP!

Cheers from Uruguay!

@pavlobu
Copy link
Owner

pavlobu commented Feb 21, 2021

@schiappa Thank you for your help! Looking forward for app translations 🙏

@pavlobu
Copy link
Owner

pavlobu commented Feb 21, 2021

@taotieren With your awesome help we now have Deskreen website and App v1.0.7 both localized to Chinese language!
You are the first one to finish both app and website translations @taotieren thank you very much ! 🎉
You rock!🤟

@pavlobu
Copy link
Owner

pavlobu commented Feb 21, 2021

Hey everyone! In case if some of you plan to add translations for German, my friend is already doing that. But he is not a native German speaker, but leaves in Germany for quite a long time.
I will be creating a pull request with German translations for app and website soon. I'm waiting for website translations from him. He already made translations for app.
In case if you know German and found typo, your fixes will be highly welcome in future!

Cheers,
Paul

This was referenced Feb 23, 2021
@pavlobu
Copy link
Owner

pavlobu commented Feb 23, 2021

Thanks to @taotieren now we have Traditional Chinese translations in v1.0.8
Thank you @taotieren for your awesome work 🙏

@schiappa
Copy link
Contributor

Hi again, Paul @pavlobu

I've committed the Spanish translations for both the host and the client Deskreen app! The PR is waiting for confirmation here: #125 (although there's a test -Codecov/project's one- that is failing -because it will decreases coverage by 0.08% when merged-, so I appreciate your help for solving that)

This PR, along with the one for the website resources I made three days ago, would complete Deskreen's support for Spanish language.

I hope I have helped, and I remain available for anything else you may need.

Regards,

Santiago.

@pavlobu
Copy link
Owner

pavlobu commented Feb 25, 2021

@schiappa Thank you a lot for your great work! 🙏
I have added Spanish translations in v1.0.10 🎉

Spanish speaking users will be super excited with your update :)

@pavlobu
Copy link
Owner

pavlobu commented Mar 8, 2021

with @LauritsLL and @Aceto1
now we have Danish and German languages support in release v1.0.11 🎉

thank you very much for your work! 🙏

@iampolychron
Copy link

Hi @pavlobu,
I am from Greece and I would like greek to be supported. I can translate, too !*
If you want, I can get a file, edit it and then send it to you.

Have a nice afternoon!

@pavlobu
Copy link
Owner

pavlobu commented Mar 31, 2021

@sadpolychron
Hi thanks! Your help is welcome!
You can go through these instructions it is friendly for both developers and non-developers.
https://github.com/pavlobu/deskreen/blob/master/doc/translations-docs/how-to-add-new-language-translation-to-Deskreen.md

Please ask if you struggle with something.

Cheers,
Paul

@pavlobu
Copy link
Owner

pavlobu commented Apr 2, 2021

With the great help of Linus Virtanen
we now have translation files for website and app to Finnish!
I'll be adding it in new release soon

@amiria703
Copy link

amiria703 commented May 3, 2022

Hello from Iran 🇮🇷 !
I want to add Persian but as far as I can see, there isn't any RTL support in both website and app.

@pavlobu
Copy link
Owner

pavlobu commented May 3, 2022

@amiria703 thanks for being motivated. Yeah, unfortunately I didn't think of a design for RTL support yet. But if you think you can help, it is definitely encouraged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants