Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources added for Spanish translations #125

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Resources added for Spanish translations #125

merged 1 commit into from
Feb 25, 2021

Conversation

schiappa
Copy link
Contributor

This commit adds the translations into Spanish for both the host and client app!

@codecov-io
Copy link

Codecov Report

Merging #125 (ea22067) into master (671763b) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   64.32%   64.23%   -0.09%     
==========================================
  Files         135      135              
  Lines        2164     2167       +3     
  Branches      210      210              
==========================================
  Hits         1392     1392              
- Misses        635      638       +3     
  Partials      137      137              
Flag Coverage Δ
unittests 64.23% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/main.dev.ts 71.96% <0.00%> (-2.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 671763b...ea22067. Read the comment docs.

@pavlobu
Copy link
Owner

pavlobu commented Feb 25, 2021

Hi Santiago @schiappa ,
Thank you very much for your great work 🙏
Codecov check is fine, I've downloaded your code and translations are looking fantastic!
Making a new minor release with it right now along with adding new language to a website.

Thanks again,
Paul

@pavlobu pavlobu merged commit b4a1aa5 into pavlobu:master Feb 25, 2021
@pavlobu
Copy link
Owner

pavlobu commented Feb 25, 2021

Now your work is added in v1.0.10 🎉
Thank a lot Santiago @schiappa ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants