REF: remove traceback from error code, it might cause a security risk…

…. Fix any errors on the backend side.
pavlov99 · Oct 28, 2017 · 027e432 · 027e432
1 parent 2781578
commit 027e432
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 12 deletions.
diff --git a/jsonrpc/manager.py b/jsonrpc/manager.py
@@ -1,5 +1,3 @@
-import sys
-import traceback
 import json
 import logging
 from .utils import is_invalid_params
@@ -115,9 +113,6 @@ def response(**kwargs):
                         "type": e.__class__.__name__,
                         "args": e.args,
                         "message": str(e),
-                        "traceback": ''.join(
-                            traceback.format_exception(*sys.exc_info())
-                        ),
                     }
 
                     logger.exception("API Exception: {0}".format(data))

diff --git a/jsonrpc/tests/test_manager.py b/jsonrpc/tests/test_manager.py
@@ -1,4 +1,3 @@
-import os
 import sys
 
 from ..manager import JSONRPCResponseManager
@@ -133,9 +132,6 @@ def test_server_error(self):
             response.error["data"]['args'], ('error_explanation',))
         self.assertEqual(
             response.error["data"]['message'], "'error_explanation'")
-        self.assertIn('traceback', response.error["data"])
-        self.assertIn(
-            os.path.basename(__file__), response.error["data"]['traceback'])
 
     def test_notification_calls_method(self):
         request = JSONRPC20Request("long_time_method", is_notification=True)
@@ -169,9 +165,6 @@ def test_type_error_inside_method(self):
             response.error["data"]['args'], ('TypeError inside method',))
         self.assertEqual(
             response.error["data"]['message'], 'TypeError inside method')
-        self.assertIn('traceback', response.error["data"])
-        self.assertIn(
-            os.path.basename(__file__), response.error["data"]['traceback'])
 
     def test_invalid_params_before_dispatcher_error(self):
         request = JSONRPC20Request(