Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds IDE specifics to gitignore #8

Merged
merged 1 commit into from Sep 12, 2019
Merged

fix: adds IDE specifics to gitignore #8

merged 1 commit into from Sep 12, 2019

Conversation

bartoszmajsak
Copy link
Contributor

Thanks for putting this tool together. It looks like something I've been thinking of :)

As I'm digging into the code I noticed that .gitignore is rather simple and configuration of my IDE of choice might accidentally be added to the repo. So I extended it based on my other project. Might prevent surprises in future contributions.

@pavolloffay
Copy link
Owner

LGTM. I would recommend using system global .gitignore for your development environment.

Thanks for your contribution!

@pavolloffay pavolloffay merged commit 57cc336 into pavolloffay:master Sep 12, 2019
@bartoszmajsak
Copy link
Contributor Author

LGTM. I would recommend using system global .gitignore for your development environment.

Sure, I do use that. The thing is - you cannot enforce that on every single contributor on the planet, so having it in the repo prevents from dumping random files which are irrelevant.

@bartoszmajsak bartoszmajsak deleted the gitignore_update branch September 12, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants