Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back support for volume control endpoints #47

Closed
wants to merge 1 commit into from

Conversation

SebuZet
Copy link

@SebuZet SebuZet commented Aug 17, 2021

I've restored support for Volume Control Endpoints.
I'm using this functionality to control volume on my Soekris R2R DAC (dam1021) using built-in HW volume control.
As an example of usage you can see my dac extension:

https://github.com/SebuZet/soekris_dac_roon

@pavoni
Copy link
Owner

pavoni commented Aug 17, 2021

Thanks @SebuZet - I'll take a proper look at this.

Could you add an example of how to use this code to the examples directory?

It's in lieu of documentation for anyone looking to use it (including me!)

Copy link
Owner

@pavoni pavoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

My main request is for you to add an example of using this part of the api to the examples directory (mainly because it acts as simple documentation)

There also looks to be a formatting issue that to automatic build process caught.

@@ -51,6 +52,10 @@ class RoonApi: # pylint: disable=too-many-instance-attributes
_state_callbacks = []
ready = False

_volume_controls_request_id = None
_volume_controls = {}
_state_callbacks = []
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assignment is duplicated

@pavoni
Copy link
Owner

pavoni commented Oct 22, 2021

Just wanted to check if you're still planning to complete this? Otherwise will close the PR.

@pavoni pavoni closed this Oct 25, 2021
@pavoni
Copy link
Owner

pavoni commented Oct 25, 2021

Closed since it's gone stale. Happy to re-open...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants