Render encoded image links #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paw-lu
force-pushed
the
encoded-image-link
branch
2 times, most recently
from
f789001
to
bfba4b9
Compare
paw-lu
force-pushed
the
encoded-image-link
branch
4 times, most recently
from
5786cc0
to
bafe621
Compare
paw-lu
force-pushed
the
encoded-image-link
branch
from
bafe621
to
8bfcea0
Compare
paw-lu
force-pushed
the
encoded-image-link
branch
from
8bfcea0
to
32fd3e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notebooks can have some messy HTML.
Where the entire base64 encoded image is in the
src. nbpreview previously treated this as a filename, which led to exceptions being raised because it's very long.With this change nbpreview not properly decodes these kinds of images, and additionally has some guards to catch issues like this and fail gently.
Fixes #496