Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When I download multiple files at the same time, more than five #68

Closed
zhsrain opened this issue Sep 2, 2020 · 12 comments
Closed

When I download multiple files at the same time, more than five #68

zhsrain opened this issue Sep 2, 2020 · 12 comments
Labels
bug Something isn't working

Comments

@zhsrain
Copy link

zhsrain commented Sep 2, 2020

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. start downloads with --enable-rpc
  2. Run command 'aria2c -x 3 -k 1M --max-overall-download-limit=4M --max-concurrent-downloads=3 -c --enable-rpc -P -d /home/'
  3. next Run command 'aria2p show'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.
image

System (please complete the following information):

  • aria2p version: [e.g. 0.9.1]
  • Python version: [e.g. 3.6]
  • OS: [Windows/Linux]

Additional context
Add any other context about the problem here.

@pawamoy pawamoy added bug Something isn't working and removed unconfirmed labels Sep 2, 2020
@pawamoy
Copy link
Owner

pawamoy commented Sep 2, 2020

Hello, thank you for the bug report 🙂

I'll investigate ASAP!

@pawamoy
Copy link
Owner

pawamoy commented Sep 3, 2020

I cannot reproduce with more than 5 active Linux torrent downloads. Is it possible for you to share the downloads links/magnets/torrents that causing the issue? You can send them to me privately at pawamoy@pm.me if you want. It will help for debugging this.

You can also only share the aria2 download info. Copy the GID of the download causing the issue, then run this command:

aria2p call tellstatus -P GID

...and paste the output here.

@zhsrain
Copy link
Author

zhsrain commented Sep 7, 2020

image
Maybe I described the error. You can use this command to test
[1]
aria2c -x 3 -k 1M --max-overall-download-limit=4M --max-concurrent-downloads=3 -c --enable-rpc -P -d /home/
[2]
aria2p add "http://{mirrors.aliyun.com/centos,ftp.cuhk.edu.hk/pub/Linux,mirrors.tuna.tsinghua.edu.cn}/centos/7.8.2003/isos/x86_64/CentOS-7-x86_64-Minimal-2003.iso"
aria2p add "http://{mirrors.aliyun.com/centos,ftp.cuhk.edu.hk/pub/Linux,mirrors.tuna.tsinghua.edu.cn}/centos/7.8.2003/isos/x86_64/CentOS-7-x86_64-DVD-2003.iso"
aria2p add "http://{mirrors.aliyun.com/centos,ftp.cuhk.edu.hk/pub/Linux,mirrors.tuna.tsinghua.edu.cn}/centos/7.8.2003/isos/x86_64/CentOS-7-x86_64-Everything-2003.iso"
aria2p add "http://{mirrors.aliyun.com/centos,ftp.cuhk.edu.hk/pub/Linux,mirrors.tuna.tsinghua.edu.cn}/centos/7.8.2003/isos/x86_64/CentOS-7-x86_64-NetInstall-2003.iso"
[3]
aria2p show

@pawamoy
Copy link
Owner

pawamoy commented Sep 7, 2020

I still cannot reproduce, but I'll catch that exception anyway.

@zhsrain
Copy link
Author

zhsrain commented Sep 17, 2020

I finally reproduced this bug. The aria2p show command needs to be executed in the download directory

@zhsrain
Copy link
Author

zhsrain commented Sep 17, 2020

image

@pawamoy
Copy link
Owner

pawamoy commented Sep 17, 2020

Ah, great, thank you! I'll see and fix that asap

@windowswithoutborders
Copy link

Just ran into this bug as well. Didn't realize it was caused by running aria2p within the download destination directory.

@pawamoy
Copy link
Owner

pawamoy commented Feb 18, 2021

Dang I forgot about this 😑

I will try to find some time soon to fix it (and I saved this in my notifications this time, to not forget).

@pawamoy
Copy link
Owner

pawamoy commented Dec 17, 2021

So, finally I' trying to solve this, apologies about the long wait...
Unfortunately, I still cannot replicate. I added torrents and direct downloads, went into the download folder and ran aria2p show, and it worked fine. Could you tell me if you still experience this issue @windowswithoutborders @zhsrain?

@tobih7
Copy link

tobih7 commented Mar 12, 2022

When running aria2p show inside the download folder everything works also for me. But when instead running aria2.get_downloads() and then trying to get the name from the Download object this error occurs.

There is this line of code inside name():

file_path = str(self.files[0].path.absolute())

It should be the complete path to the file, and it is when running with aria2p show.
But when running manually from within Python it is just the download directory without the file name.
That's where the IndexError comes from.

I don't know why exactly this happens, but it only happens when instantly trying to get the name after starting the download.
When waiting a second before getting the name everything works.

Hope this helps.

@pawamoy
Copy link
Owner

pawamoy commented Apr 17, 2022

Can't replicate so I simply catch the error. The name will remain empty until aria2c returns the right information.

@pawamoy pawamoy closed this as completed Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants