Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License File was created but empty #8

Closed
meramsey opened this issue Mar 9, 2021 · 3 comments
Closed

License File was created but empty #8

meramsey opened this issue Mar 9, 2021 · 3 comments

Comments

@meramsey
Copy link
Contributor

meramsey commented Mar 9, 2021

I noticed i had a license file but it was empty even though i had selected MIT license in the installer.

Showed in pyproject.toml file but file was empty.
license = "MIT License"

Is it supposed to pull down and fill it with the appropriate boilerplate one? If not that fine but it was slightly confusing.

Just in case it is useful output from when i generated the project.

onessa@onessa-All-Series:~$ pip install --user copier
Collecting copier
  Downloading copier-5.1.0-py3-none-any.whl (22 kB)
Requirement already satisfied: colorama<0.5.0,>=0.4.3 in /usr/lib/python3/dist-packages (from copier) (0.4.3)
Requirement already satisfied: pyyaml<6.0.0,>=5.3.1 in /usr/lib/python3/dist-packages (from copier) (5.3.1)
Collecting pyyaml-include<2.0,>=1.2
  Downloading pyyaml_include-1.2.post2-py3-none-any.whl (20 kB)
Collecting jinja2<3.0.0,>=2.11.2
  Downloading Jinja2-2.11.3-py2.py3-none-any.whl (125 kB)
     |████████████████████████████████| 125 kB 1.2 MB/s 
Collecting plumbum<2.0.0,>=1.6.9
  Downloading plumbum-1.7.0-py2.py3-none-any.whl (116 kB)
     |████████████████████████████████| 116 kB 1.1 MB/s 
Collecting packaging<21.0,>=20.4
  Downloading packaging-20.9-py2.py3-none-any.whl (40 kB)
     |████████████████████████████████| 40 kB 1.3 MB/s 
Collecting regex<2021.0.0,>=2020.6.8
  Downloading regex-2020.11.13-cp38-cp38-manylinux2014_x86_64.whl (738 kB)
     |████████████████████████████████| 738 kB 1.3 MB/s 
Collecting pydantic<2.0.0,>=1.5.1
  Downloading pydantic-1.8.1-cp38-cp38-manylinux2014_x86_64.whl (13.7 MB)
     |████████████████████████████████| 13.7 MB 1.9 MB/s 
Collecting pathspec<0.9.0,>=0.8.0
  Downloading pathspec-0.8.1-py2.py3-none-any.whl (28 kB)
Requirement already satisfied: MarkupSafe>=0.23 in /usr/lib/python3/dist-packages (from jinja2<3.0.0,>=2.11.2->copier) (1.1.0)
Requirement already satisfied: pyparsing>=2.0.2 in /usr/lib/python3/dist-packages (from packaging<21.0,>=20.4->copier) (2.4.6)
Collecting typing-extensions>=3.7.4.3
  Downloading typing_extensions-3.7.4.3-py3-none-any.whl (22 kB)
Installing collected packages: pyyaml-include, jinja2, plumbum, packaging, regex, typing-extensions, pydantic, pathspec, copier
Successfully installed copier-5.1.0 jinja2-2.11.3 packaging-20.9 pathspec-0.8.1 plumbum-1.7.0 pydantic-1.8.1 pyyaml-include-1.2.post2 regex-2020.11.13 typing-extensions-3.7.4.3
WARNING: You are using pip version 20.2.3; however, version 21.0.1 is available.
You should consider upgrading via the '/usr/bin/python3.8 -m pip install --upgrade pip' command.
onessa@onessa-All-Series:~$ copier "gh:pawamoy/copier-poetry" PycharmProjects/domaininfowizard

Your project name
project_name? Format: str
🎤 [None]: Wizard Domaininfo

Your project description
project_description? Format: str
🎤 [None]: DNS/Whois Domain Information library

Your full name
author_fullname? Format: str
🎤 [None]: Michael Ramsey

Your email
author_email? Format: str
🎤 [None]: mike@hackerdise.me

Your username (e.g. on GitHub)
author_username? Format: str
🎤 [None]: mikeramsey

Your repository provider
repository_provider? Format: str
🎤
(1) github.com
(2) gitlab.com
(3) bitbucket.org
Choice [1]: 2

Your repository namespace
repository_namespace? Format: str
🎤 [mikeramsey]: 

Your repository name
repository_name? Format: str
🎤 [wizard-domaininfo]: 

The name of the person/entity holding the copyright
copyright_holder? Format: str
🎤 [Michael Ramsey]: 

The email of the person/entity holding the copyright
copyright_holder_email? Format: str
🎤 [mike@hackerdise.me]: 

The copyright date
copyright_date? Format: str
🎤 [2020]: 2021

Your project's license
copyright_license? Format: str
🎤
(1) Academic Free License v3.0
(2) Apache License 2.0
(3) Artistic License 2.0
(4) BSD 2-Clause "Simplified" License
(5) BSD 3-Clause Clear License
(6) BSD 3-Clause "New" or "Revised" License
(7) Boost Software License 1.0
(8) Creative Commons Attribution 4.0
(9) Creative Commons Attribution Share Alike 4.0
(10) Creative Commons Zero v1.0 Universal
(11) Do What The F*ck You Want To Public License
(12) Educational Community License v2.0
(13) Eclipse Public License 1.0
(14) Eclipse Public License 2.0
(15) European Union Public License 1.1
(16) European Union Public License 1.2
(17) GNU Affero General Public License v3.0
(18) GNU General Public License v2.0
(19) GNU General Public License v3.0
(20) GNU Lesser General Public License v2.1
(21) GNU Lesser General Public License v3.0
(22) ISC License
(23) LaTeX Project Public License v1.3c
(24) MIT License
(25) Mozilla Public License 2.0
(26) Microsoft Public License
(27) Microsoft Reciprocal License
(28) University of Illinois/NCSA Open Source License
(29) SIL Open Font License 1.1
(30) Open Software License 3.0
(31) PostgreSQL License
(32) The Unlicense
(33) zlib License
Choice [22]: 24

Your Python package distribution name (for `pip install NAME`)
python_package_distribution_name? Format: str
🎤 [wizard-domaininfo]: wizard_domaininfo

Your Python package import name (for `import NAME` in Python code)
python_package_import_name? Format: str
🎤 [wizard_domaininfo]: 

Your CLI name if any (for use in the shell)
python_package_command_line_name? Format: str
🎤 [wizard-domaininfo]: 

    create  README.md
    create  .gitignore
    create  CODE_OF_CONDUCT.md
    create  CONTRIBUTING.md
    create  .gitlab-ci.yml
    create  duties.py
    create  LICENSE
    create  Makefile
    create  .copier-answers.yml
    create  mkdocs.yml
    create  pyproject.toml
    create  CHANGELOG.md
    create  src/
    create  src/wizard_domaininfo/
    create  src/wizard_domaininfo/cli.py
    create  src/wizard_domaininfo/__main__.py
    create  src/wizard_domaininfo/__init__.py
    create  docs/
    create  docs/credits.md
    create  docs/changelog.md
    create  docs/index.md
    create  docs/license.md
    create  docs/contributing.md
    create  docs/macros.py
    create  docs/code_of_conduct.md
    create  docs/reference/
    create  docs/reference/cli.md
    create  docs/css/
    create  docs/css/mkdocstrings.css
    create  scripts/
    create  scripts/post_generation.py
    create  scripts/setup.sh
    create  scripts/multirun.sh
    create  .github/
    create  .github/FUNDING.yml
    create  .github/workflows/
    create  .github/workflows/ci.yml
    create  .github/ISSUE_TEMPLATE/
    create  .github/ISSUE_TEMPLATE/feature_request.md
    create  .github/ISSUE_TEMPLATE/bug_report.md
    create  config/
    create  config/mypy.ini
    create  config/pytest.ini
    create  config/coverage.ini
    create  tests/
    create  tests/test_cli.py
    create  tests/__init__.py
    create  tests/conftest.py

 > Running task 1 of 1: python scripts/post_generation.py
Project sucessfully generated!
Run `make` to show the available actions.

onessa@onessa-All-Series:~$
@pawamoy
Copy link
Owner

pawamoy commented Mar 10, 2021

Hi @whattheserver, thanks for the report! I couldn't see anything wrong in the code yet. I'll try to add a test to check that the license file was correctly rendered.

@pawamoy
Copy link
Owner

pawamoy commented Mar 10, 2021

Ah! The error was obvious 😑

The templated LICENSE uses a variable named license instead of copyright_license.

Will fix this immediatly 🙂

@pawamoy
Copy link
Owner

pawamoy commented Mar 10, 2021

I'll try to release soon, this is fixed 🙂

@pawamoy pawamoy closed this as completed Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants