Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update display of matrix #48

Merged
merged 1 commit into from Jun 13, 2022
Merged

Update display of matrix #48

merged 1 commit into from Jun 13, 2022

Conversation

vladdu
Copy link
Contributor

@vladdu vladdu commented Jun 13, 2022

If the names of all packages are shorter than "Module", then the header is not aligned with the rest of the table.

If the names of all packages are shorter than "Module", then the header is not aligned with the rest of the table.
Copy link
Owner

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot!

@pawamoy
Copy link
Owner

pawamoy commented Jun 13, 2022

OK, CI is failing because it's a bit outdated. Your change is good though so I'll merge and then put back the project in shape. Thanks again 🙂

@pawamoy pawamoy merged commit 1ee922c into pawamoy:master Jun 13, 2022
pawamoy pushed a commit that referenced this pull request Jun 13, 2022
If the names of all packages are shorter than "Module", then the header is not aligned with the rest of the table.

PR #48: #48
@vladdu vladdu deleted the patch-1 branch June 13, 2022 17:44
@pawamoy
Copy link
Owner

pawamoy commented Jun 13, 2022

@vladdu do you want me to cut a new release with your bugfix (it's only a matter of seconds/minutes)? Or would you rather send other PRs first?

@vladdu
Copy link
Contributor Author

vladdu commented Jun 13, 2022

This isn't an important thing to release, but maybe you want to test the release pipeline, given that the rest needed some work to update? I will try to send more changes, but I guess we will need to discuss if the API is ok, so that might take a while to get right.

@pawamoy
Copy link
Owner

pawamoy commented Jun 13, 2022

3.3.1 released 😄 The release process went well 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants