Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #100 - Fix docs build #101

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix #100 - Fix docs build #101

merged 1 commit into from
Aug 28, 2023

Conversation

stinovlas
Copy link
Collaborator

Fix ReadTheDocs build.

@stinovlas stinovlas self-assigned this Aug 28, 2023
@stinovlas stinovlas mentioned this pull request Aug 28, 2023
@stinovlas
Copy link
Collaborator Author

I'd like to test the build with RTD before we merge this, but I think we'll have to work out the webhooks/integration first.

@pawamoy
Copy link
Owner

pawamoy commented Aug 28, 2023

@stinovlas
Copy link
Collaborator Author

stinovlas commented Aug 28, 2023

It passed: https://readthedocs.org/projects/django-appsettings/builds/21738595/ 🙂

Yeah, looks good. Is the integration set for the push to master branch? If so, it should be safe to merge this.

@pawamoy
Copy link
Owner

pawamoy commented Aug 28, 2023

There's no particular setting for this so I suppose it's done by default 🤔

@stinovlas stinovlas merged commit 1aa11c3 into master Aug 28, 2023
1 check passed
@stinovlas stinovlas deleted the 100-fix-docs branch August 28, 2023 09:11
@stinovlas
Copy link
Collaborator Author

And we're up and running :-). The only version showed is latest, but I think that's OK, considering there's Changelog included in the docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants