Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Chose a provider explicitly #37

Closed
TheoGoudout opened this issue Feb 22, 2023 · 3 comments
Closed

Feature: Chose a provider explicitly #37

TheoGoudout opened this issue Feb 22, 2023 · 3 comments

Comments

@TheoGoudout
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When working on a repo hosted on a private Gitlab instance, provider detection is not working

Describe the solution you'd like
It would be nice to be able to specify explicitly that an instance is running on Gilab. That would solve the missing compare links.

Describe alternatives you've considered
The only alternative I can think of is adding these links manually.
@pawamoy
Copy link
Owner

pawamoy commented Feb 24, 2023

Good suggestion. I remember having tried to do that elegantly before but failed / give up. Reviewing your PR now!

@pawamoy pawamoy mentioned this issue Feb 24, 2023
Closed
@TheoGoudout TheoGoudout mentioned this issue Feb 28, 2023
Merged
pawamoy pushed a commit that referenced this issue Aug 21, 2023
@TheoGoudout
feat: Add provider CLI option
908531b 
Issue #37: #37
PR #40: #40
Co-authored-by: Théo Goudout <theo.goudout@gmail.com>
Co-authored-by: Timothée Mazzucotelli <pawamoy@pm.me>
@sandzhaj
Copy link
Contributor

sandzhaj commented Oct 8, 2023

@pawamoy actually #55 resolves that. I had the same problem, but specified provider in pyproject.toml
Works well
Maybe it's time to release new tag? :)

@pawamoy
Copy link
Owner

pawamoy commented Oct 8, 2023

Done!

@pawamoy pawamoy closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pawamoy @TheoGoudout @sandzhaj