Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build should fail when strict mode and warnings #86

Closed
pawamoy opened this issue Apr 14, 2020 · 0 comments
Closed

Build should fail when strict mode and warnings #86

pawamoy opened this issue Apr 14, 2020 · 0 comments
Labels
bug Something isn't working logging Related logging messages

Comments

@pawamoy
Copy link
Member

pawamoy commented Apr 14, 2020

Currently the warning will not make the build fail.

Hook properly the loggers so that the build fails if any warning has been issued.

Additionally, any log with level greater than warning should also make the build fail, let's see what happens in mkdocs/mkdocs#2064

@pawamoy pawamoy added bug Something isn't working logging Related logging messages labels Apr 14, 2020
pawamoy added a commit that referenced this issue Apr 14, 2020
With strict mode (`-s` option for build and serve
commands of MkDocs), the build should fail if any
warning has been issued.

This was not the case. This commit adds the
`warning_filter` counter declared and used by
MkDocs to loggers in all modules.

Reference: #86.
pawamoy added a commit that referenced this issue Apr 14, 2020
With strict mode (`-s` option for build and serve
commands of MkDocs), the build should fail if any
warning has been issued.

This was not the case. This commit adds the
`warning_filter` counter declared and used by
MkDocs to loggers in all modules.

Reference: #86.
@pawamoy pawamoy closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging Related logging messages
Projects
None yet
Development

No branches or pull requests

1 participant