Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shell code for ZSH #23

Merged
merged 3 commits into from
Apr 30, 2019
Merged

Fix shell code for ZSH #23

merged 3 commits into from
Apr 30, 2019

Conversation

pawamoy
Copy link
Owner

@pawamoy pawamoy commented Apr 14, 2019

Issue #20 and #3.

Copy link
Owner Author

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First review, waiting for feedback. Will try to fix what I can.

src/shellhistory/shellhistory.sh Outdated Show resolved Hide resolved
src/shellhistory/shellhistory.sh Outdated Show resolved Hide resolved
src/shellhistory/shellhistory.sh Outdated Show resolved Hide resolved
src/shellhistory/shellhistory.sh Outdated Show resolved Hide resolved
src/shellhistory/shellhistory.sh Outdated Show resolved Hide resolved
@pawamoy
Copy link
Owner Author

pawamoy commented Apr 26, 2019

Everything should be good now, I'm gonna run some more tests and merge when I'm sure it's working correctly in both Bash and Zsh.

@pawamoy
Copy link
Owner Author

pawamoy commented Apr 30, 2019

Just tested, it's working fine in both Bash and Zsh. Merging 🎉

@pawamoy pawamoy merged commit 452c42a into master Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant