Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow dom support #142

Open
lukawski opened this issue Mar 11, 2018 · 0 comments
Open

Shadow dom support #142

lukawski opened this issue Mar 11, 2018 · 0 comments

Comments

@lukawski
Copy link

lukawski commented Mar 11, 2018

Hello,

First of all thanks for great project! It was wonderful idea to create core for carousel which might be extended to become very advanced solution.

I'm currently working with Polymer and Web Components. I think it might be a good idea to provide support for shadow dom .

For example let's say I have carousel-siema element. Inside its shadow dom I have div element with id siema. And inside that I have slot. It acts as an insert point for elements that I wish to have inside carousel. And this piece of code: [].slice.call(this.selector.children) is not gonna work as those elements are not div#siema children.

If you are okay with that I have an idea how to solve this. It would require changing one line of code and adding two options to config object. But if it will break "lightweight and simple carousel" rule then I understand.

@lukawski lukawski changed the title Shadow root support Shadow dom support Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant