Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

every consecutive clicked link overwrites the 2nd tab #20

Closed
mavgink opened this issue Jun 10, 2021 · 2 comments · Fixed by #21
Closed

every consecutive clicked link overwrites the 2nd tab #20

mavgink opened this issue Jun 10, 2021 · 2 comments · Fixed by #21
Assignees
Labels
🐞 Bug Something isn't working
Milestone

Comments

@mavgink
Copy link

mavgink commented Jun 10, 2021

I noticed that if I for instance want to open 3 applications. The 2nd and 3rd click will always overwrite the first opened tab. Is is possible to always open a new tab? (tested in firefox and safari)

@vp-lab
Copy link

vp-lab commented Jun 10, 2021

Yes, I encountered this problem on Firefox, Chrome.
It'll be nice to open new tab every time.

@PossessedC0bra
Copy link

The issue is the wrong use of the target attribute. Currently the value is set to target='blank' which is incorrect. Instead target='_blank' should be used.

<a href={`http://${props.app.url}`} target='blank' className={classes.AppCard}>

<a
href={`http://${bookmark.url}`}
target='blank'
key={`bookmark-${bookmark.id}`}>
{bookmark.name}
</a>

@pawelmalak pawelmalak self-assigned this Jun 10, 2021
@pawelmalak pawelmalak added the 🐞 Bug Something isn't working label Jun 10, 2021
@pawelmalak pawelmalak added this to the Version 1.2 milestone Jun 10, 2021
@pawelmalak pawelmalak linked a pull request Jun 10, 2021 that will close this issue
aroberts pushed a commit to aroberts/flame that referenced this issue Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants