Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter items #47

Closed
gitcatpeter opened this issue Jun 23, 2021 · 7 comments · Fixed by #84
Closed

Filter items #47

gitcatpeter opened this issue Jun 23, 2021 · 7 comments · Fixed by #84
Assignees
Labels
🔨 Feature New feature or request

Comments

@gitcatpeter
Copy link

I think it would be good to add an app/bookmark filter.
Kind of a search box. Typing in there would narrow down displayed items.

With a large amount of items it would ease finding the right one.

I like how it is done in dashy, working demo here (just type firs letter (s))
https://dashy-demo-1.as93.net/#/

Maybe something to consider later?

@kimpenhaus
Copy link

Hi all,

I would backen this and like to see the filter in the search bar - more concrete when no prefix is given.

Currently one will see an error notification:
image

So there might be an detection already one can hook up to.

Thanks, m.

@pawelmalak
Copy link
Owner

It's a little tricky beacuse search bar is located on home screen where only pinned elements are located and there is a problem where the results should be displayed.

Should only pinned items be filtered?

@kimpenhaus
Copy link

kimpenhaus commented Aug 6, 2021

Uh - I just didn't knew that there is an option with pinned and not pinned bookmarks 🙈

So all my bookmarks are pinned, obviously and I would be fine with just filtering pinned items.

Maybe as a first start... and enhance later 🤷

@gitcatpeter
Copy link
Author

gitcatpeter commented Aug 7, 2021 via email

@kimpenhaus
Copy link

Another option but more complex could be to add an filter/search endpoint to the api and crawl while typing. (start crawling after x characters typed) Could maybe also used to preview search results while using a prefix.

Just thoughts...

@gitcatpeter
Copy link
Author

Any chance to get this filtering going?
I've been using your app ever since and it worked great, however I have so many items I'd really love to have the search/filter function available.
Thanks!

@pawelmalak pawelmalak added the 🔨 Feature New feature or request label Sep 6, 2021
@pawelmalak pawelmalak self-assigned this Sep 6, 2021
@pawelmalak pawelmalak linked a pull request Sep 6, 2021 that will close this issue
@kimpenhaus
Copy link

@pawelmalak awesome - thaks mate! 🙏🏼

one more question - not sure if I should open a ticket for that. 😄
how to reset the filter? I would assume to just remove the filter query string... but that won't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants