Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[y_text] Keys (~k~~KEY_NAME~) don't work on client messages or gametexts #235

Closed
Vasily-X opened this issue Oct 6, 2017 · 1 comment
Closed

Comments

@Vasily-X
Copy link
Contributor

Vasily-X commented Oct 6, 2017

I guess that's because of Y_Less didn't add support for them, back in the days keys couldn't be used in client messages. I'll look into this.

EDIT: just realized they don't work on GameTexts either!

Regards.

@Vasily-X Vasily-X changed the title [y_text] Keys (~k~~KEY_NAME~) don't work on client messages [y_text] Keys (~k~~KEY_NAME~) don't work on client messages or gametexts Oct 6, 2017
@Vasily-X
Copy link
Contributor Author

Vasily-X commented Oct 6, 2017

Okay, I found Format_GetKeys:
https://github.com/Misiur/YSI-Includes/blob/6aa029a027aabf17555b2073426ac1a363641a86/YSI_Players/y_text/load.inc#L193

Seems it compresses the key string using https://github.com/Misiur/YSI-Includes/blob/6aa029a027aabf17555b2073426ac1a363641a86/YSI_Players/y_text/load.inc#L101.

Not sure how correct is that after all, given:
https://github.com/Misiur/YSI-Includes/blob/6aa029a027aabf17555b2073426ac1a363641a86/YSI_Players/y_text/load.inc#L976

On the other hand, I think this bug is caused by Text_Render, I didn't find any rendering code for keys yet. Only this:

case '\04':
{
	P:6("Text_Render: Key");
	++idx;
}

Maybe the key string is not being unpacked, not sure.

@Y-Less Y-Less closed this as completed in 420e0d5 Jan 18, 2018
Y-Less added a commit that referenced this issue Jan 28, 2018
Y-Less added a commit that referenced this issue Jan 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant