[MERGED] Fix the array return bug #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpressions inside a single `return` statement
Example:
```
StringOrigin()
{
static const string[] = "Hello world";
return string;
}
ReturnString()
{
return StringOrigin(), StringOrigin();
}
```
Before this fix, the heap space allocated by the first `StringOrigin()` call wasn't being freed.
3 tasks
|
Is that produce memory leaks in run-time? |
It doesn't leak, no. Pawn itself doesn't really have memory leaks, those all come from plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes bad code generation when returning an array returned by another function (see #293).
Which issue(s) this PR fixes:
Fixes #293
What kind of pull this is:
Additional Documentation:
The test code is based on the array return bug demonstration by @Southclaws.