Fixes for redefinition of enum root symbols #577

Daniel-Cortez · 2020-09-30T11:16:08Z

What this PR does / why we need it:

This PR does the following:

Fixes crash when an enum root symbol is redefined by an enum constant (Crash with untagged enums #403).
Fixes the compiler not warning when redefining a root symbol of an empty named enum (No warnings when redefining empty named enumerations #575).

Which issue(s) this PR fixes:

What kind of pull this is:

Additional Documentation:

The nesting level is already set in `add_constant()`.

Daniel-Cortez added 4 commits September 30, 2020 00:42

Warn when an empty enum root symbol gets redefined

389b13d

Properly handle "enum root" symbols being redefined by enum elements

1c2b765

Remove redundant code from decl_enum()

ea87f9d

The nesting level is already set in `add_constant()`.

Add tests

d621b85

Daniel-Cortez requested a review from a team as a code owner September 30, 2020 11:16

Y-Less merged commit 270f1f3 into pawn-lang:dev Oct 20, 2020

Daniel-Cortez deleted the fix-403 branch October 22, 2020 13:32

Daniel-Cortez mentioned this pull request Oct 22, 2020

No warnings when redefining empty named enumerations #575

Closed

Daniel-Cortez mentioned this pull request Dec 31, 2020

Crash with untagged enums #403

Open

Provide feedback