Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to gets all active connections to the database. #31

Merged

Conversation

djgoku
Copy link
Contributor

@djgoku djgoku commented Nov 9, 2022

This adds the ability to get all active connections to the database.

Screenshot 2022-11-17 at 09 17 28

@djgoku djgoku mentioned this pull request Nov 9, 2022
@djgoku
Copy link
Contributor Author

djgoku commented Nov 16, 2022

I'll be pushing an update to this tomorrow morning and adding a screenshot too.

@djgoku djgoku force-pushed the feature/add-active-connections-to-the-database branch 2 times, most recently from 395bf97 to 2b5f661 Compare November 17, 2022 15:53
@djgoku
Copy link
Contributor Author

djgoku commented Nov 17, 2022

I am done pushing changes to this PR.

@@ -13,7 +13,7 @@ defmodule EctoPSQLExtrasTest do
outliers_legacy: EctoPSQLExtras.OutliersLegacy
}

@skip_queries [:kill_all]
@skip_queries [:kill_all, :connections]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you skip it in the test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to be just a count. Looking into adding a test now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed it in the latest push.

This adds the ability to get all active connections to the database.

Co-authored-by: Matt Hall <matt.hall@binarynoggin.com>
@djgoku djgoku force-pushed the feature/add-active-connections-to-the-database branch from 2b5f661 to f807147 Compare November 21, 2022 22:08
@djgoku djgoku requested a review from pawurb November 21, 2022 22:13
@pawurb pawurb merged commit e3e5bb7 into pawurb:master Nov 21, 2022
@djgoku djgoku deleted the feature/add-active-connections-to-the-database branch November 24, 2022 00:52
@siphonhata
Copy link

Good Day, since I'm able to see the active connections. Is it possible to closed a connection whether its busy or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants