This repository has been archived by the owner on May 18, 2023. It is now read-only.
Modified speech_synthesis.rb and sound_response_handler.rb to add -t opt... #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…option for Windows.
|
I like the change. Would be great to have full functionality on windows. However your build is failing on travis so please look into it. Might be that you have to check OS before requiring 'sys/uname' which is probably not available on linux ruby versions. |
|
I think that will do it. Thanks! |
|
I don't like adding another dependency for linux and macosx and when it is not required. You could check system with Gem::Platform.local.os and require 'sys/uname' only when running on windows. Please add specs for it. |
|
Sure, that makes sense. I'll see what I can do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ion for Windows.