Fix for strong_migrations
#850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes pay-rails#849 This PR modifies the `pay_customer_owner_index` index to rely on 3 columns instead of 4, so that migrations pass for people using the `strong_migrations` gem. Here's the explanation as to why one should [keep non-unique indexes to three columns or less](https://github.com/ankane/strong_migrations#keeping-non-unique-indexes-to-three-columns-or-less)
excid3
reviewed
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #849
This PR modifies the
pay_customer_owner_indexindex to rely on 3 columns instead of 4, so that migrations pass for people using thestrong_migrationsgem. I've also made this index unique as per Chris's comment.Here's the explanation as to why one should keep non-unique indexes to three columns or less