Fix invalid client_reference_id composition #854
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to integrate the Stripe pricing table without success. I realized that the current method
Pay::Stripe.to_client_reference_id
is creating an invalid string. It includes a forward slash (likeUser/42
), which isn't allowed according to Stripe's docs:Source: https://stripe.com/docs/payments/checkout/pricing-table#handle-fulfillment-with-the-stripe-api
The resulting webhook
checkout.session.completed
then containsclient_reference_id: null
, so the client cannot be found.I changed the implementation to use an underscore instead of the slash (like
User_42
).References: #670, #823