Fix issue with Paddle Billing Charges when there's no payment details #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanpcmad
added a commit
to deanpcmad/pay
that referenced
this pull request
Oct 21, 2023
…o paddle-billing-updates * 'paddle-billing-updates' of github.com:deanpcmad/pay: Paddle Billing Docs (pay-rails#873) Update 1_installation.md with Stripe version 10 (pay-rails#880) Add Rails 7.1 to tests and remove Ruby 2.7 as it's EOL (pay-rails#878) Fix issue with Paddle Billing Charges when there's no payment details (pay-rails#872) Merge session_id into return_url for Stripe Checkout Stripe v10 Update github actions to use main branch (pay-rails#871)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on updating the docs, I found that Charges weren't being created for transactions such as updating the subscription plan.
This PR updates the payment details to only be updated if there is a
payment.