Retrieve paddle subscription with options #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The paddle gem accept the option `extra` when retrieving a subscription. See: https://github.com/deanpcmad/paddle/blob/83120a9e285cfb5daf36f7f56939e985ab029843/lib/paddle/models/subscription.rb#L11 This change allows Pay::Subscription#processor_subscription to pass options to ::Paddle::Subscription.retrieve
|
I've noticed this is not exactly what I wanted to achieve. subscription.processor_subscription(extra: 'next_transaction')Similar to how it's implemented on pay/lib/pay/stripe/subscription.rb Line 159 in bd15f22 I'll work on that to complete this PR Edit: Done ✅ 87983ce |
It enables the following: ```ruby subscription.processor_subscription( extra: 'next_transaction' ) ```
|
Maybe we should just include these extras by default? I guess we aren't using them currently, so probably just slows API requests if we do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The paddle gem accept the option
extrawhen retrieving a subscription.See: https://github.com/deanpcmad/paddle/blob/83120a9e285cfb5daf36f7f56939e985ab029843/lib/paddle/models/subscription.rb#L11
What this PR allows us to do: