Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address nillable Paddle Billing values in subscription #948

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

oliwoodsuk
Copy link
Contributor

Pull Request

Summary:
As listed here, Paddle subscription attributes next_billed_at, paused_at and scheduled_change can all be nil.
I ran into this issue when having Paddle set up in sandbox mode.

Description:
Pay::Subscription.trial_ends_at and pause_starts_at will fallback to nil is not present in the Paddle subscription.
Pay::Subscription.ends_at will default to the current date if not present, so the canceled? method works atleast.

@excid3 excid3 added the Paddle label Jan 29, 2024
@excid3 excid3 merged commit 17cc1da into pay-rails:main Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants