Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FISH-6455 Cloud Connectors examples profile #575

Merged
merged 1 commit into from
Aug 22, 2022
Merged

FISH-6455 Cloud Connectors examples profile #575

merged 1 commit into from
Aug 22, 2022

Conversation

jGauravGupta
Copy link
Contributor

No description provided.

Pandrex247
Pandrex247 approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pdudits
pdudits approved these changes Aug 22, 2022
View reviewed changes
Copy link

@pdudits pdudits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuring install and deploy plugin to <skip>true</skip> would be nicer, but not in this module structure that doesn't have common examples parent.

@jGauravGupta jGauravGupta merged commit 89d284d into payara:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdudits pdudits pdudits approved these changes

@Pandrex247 Pandrex247 Pandrex247 approved these changes

@arieki arieki Awaiting requested review from arieki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jGauravGupta @pdudits @Pandrex247