FISH-468 FISH-1181 FISH-1182 Fix Micro and Embedded Issues and Param Conflicts #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The admin audit service isn't present in Payara Micro, leading to CNFEs when you try to start it. This reworks the upgrade of this specific service into its own module and service, rather than being done as a part of each notifier upgrade. This allows us to split it out and include it separately. Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
|
Tag pre-emptively made here: https://github.com/payara/Notifiers/tree/1.0.1-enterprise |
|
Additional changes incoming. Tag deleted |
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Pandrex247
force-pushed
the
FISH-468-Fix-Deps
branch
from
730909e
to
97b8ccc
Compare
Pandrex247
changed the title
|
Tag recreated with changes brought in by 55cda2c |
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Pandrex247
force-pushed
the
FISH-468-Fix-Deps
branch
from
97b8ccc
to
400df9c
Compare
|
Tag recreated with changes brought in by 03e49c0 |
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Pandrex247
force-pushed
the
FISH-468-Fix-Deps
branch
from
400df9c
to
68d37af
Compare
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Pandrex247
force-pushed
the
FISH-468-Fix-Deps
branch
from
68d37af
to
51aaedc
Compare
Cousjava
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits out the admin audit service upgrade into its own module, since Micro doesn't have this service.
To continue to avoid CNFEs, it was written to hopefully be dynamic to the present upgrade services across the various distributions.
The abstract class that all of the upgrade services implemented has been renamed to coincide with its new nature as an actual contract. Marking it as a contract allows us to look for the services that implement it. Each of the upgrade services has also been annotated with a qualifier, which can be used to help discern programmatically which notifier it's upgrading.
Since we haven't strictly released a 1.0 I've elected to have this go out as 1.0.1 rather than continue fudging the tags.