Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-5787 Enterprise Teams Notifier Console Plugin Version Increment #22

Merged

Conversation

JamesHillyard
Copy link
Member

Teams Notifier Console Plugin 1.1-enterprise was released to Nexus

@JamesHillyard JamesHillyard merged commit 9af355c into payara:enterprise Feb 25, 2022
@JamesHillyard JamesHillyard deleted the FISH-5787-EnterpriseIncrement branch February 25, 2022 11:00
@Pandrex247
Copy link
Member

I mean it wasn't necessary to change all the versions on the 1.1 release commit - you're not rebuilding and redeploying those artefacts (or shouldn't be anyway).

For future reference, it should have looked something like this:

  • 1.1-enterprise release commit
    • Change version to 1.1-enterprise for teams-notifier-console-plugin/pom.xml
    • Change parent pom version to 1.0.1-enterprise for parent pom version in teams-notifier-console-plugin/pom.xml
  • mvn clean deploy -pl teams-notifier-console-plugin ... (so just compile and deploy the single module - 1.0.1-enterprise of the parent pom has already been deployed and doesn't need re-doing)
  • Tag teams-notifier-console-plugin-1.1-enterprise and push
  • 1.2-enterprise-SNAPSHOT commit
    • Change version to 1.2-enterprise-SNAPSHOT for teams-notifier-console-plugin/pom.xml
    • Change parent pom version back to 1.1-enterprise-SNAPSHOT for parent pom version in teams-notifier-console-plugin/pom.xml

@Pandrex247
Copy link
Member

Speaking of the tag - it's missing.
*poke* 👉

@JamesHillyard
Copy link
Member Author

Speaking of the tag - it's missing. poke 👉

Tagged now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants