FISH-651 Documented new changes for disabling JWT type verification #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndroMih
reviewed
Nov 26, 2020
| > | ||
| > Use of this Header Parameter is OPTIONAL. | ||
|
|
||
| For this reason, some third-party token issuers may generate tokens that are not compatible with the Payara Platform. The Payara Platform allows to set this verification off, so you can use the `disable.type.verification` custom property and set its value to `true` to this effect. |
There was a problem hiding this comment.
Shouldn't this be:
Suggested change
| For this reason, some third-party token issuers may generate tokens that are not compatible with the Payara Platform. The Payara Platform allows to set this verification off, so you can use the `disable.type.verification` custom property and set its value to `true` to this effect. | |
| For this reason, some third-party token issuers may generate tokens that are not compatible with the MicroProfile JWT specification. The Payara Platform allows to set this verification off, so you can use the `disable.type.verification` custom property and set its value to `true` to this effect. |
There was a problem hiding this comment.
and important to mention that when propagated to 3th party services, those tokens might be rejected when they follow the MP JWT spec rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of a custom special property to disable the verification of the standard JWT authentication token verification of the type (
typ) claim to make Payara compatible with most modern third-party token issuers.