Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I use skipdsfailure-Option in Payara Micro uberjar? #4745

Closed
deratzmann opened this issue Jun 24, 2020 · 3 comments
Closed

How do I use skipdsfailure-Option in Payara Micro uberjar? #4745

deratzmann opened this issue Jun 24, 2020 · 3 comments
Assignees
Labels
Status: Abandoned User has not supplied reproducers for bug report, soon to be closed if user doesn’t come back Status: Pending Waiting on the issue requester to give more details or share a reproducer

Comments

@deratzmann
Copy link

Description


I am just playin around with payara micro and creation of uber jars by the payara micro maven plugin. From my payara server background I remember an option called skipdsfailure which is used with the deploy command (see https://javadoc.io/doc/fish.payara.extras/payara-embedded-all/5.193.1/org/glassfish/api/deployment/DeployCommandParameters.html)
Is there any chance to use this option in an uber jar like
java -jar -Dskipdsfailure myuber.jar or append it in the configuration of the micro maven plugin like this:
<plugin> <groupId>fish.payara.maven.plugins</groupId> <artifactId>payara-micro-maven-plugin</artifactId> <version>1.0.7</version> <executions> <execution> <phase>package</phase> <goals> <goal>bundle</goal> </goals> </execution> </executions> <configuration> <commandLineOptions> <option> <value>--noCluster</value> </option> <option> <key>--contextroot</key> <value>ROOT</value> </option> <option> <key>--port</key> <value>8080</value> </option> <option> <key>skipdsfailure</key> <value>true</value> </option> </commandLineOptions> <payaraVersion>${payara-micro.version}</payaraVersion> <appendSystemProperties>true</appendSystemProperties> <deployWar>true</deployWar> </configuration> </plugin>

Environment

payara-micro-maven-plugin: 1.0.7

  • Payara Version: 5.2020.2
  • Edition: Micro
  • JDK Version: Azul jdk 8
  • Operating System: Windows
  • Database: h2

Thanks for your feedback.

Best regards.
Bastian

@rdebusscher rdebusscher self-assigned this Jul 14, 2020
@rdebusscher rdebusscher added the Status: Pending Waiting on the issue requester to give more details or share a reproducer label Jul 14, 2020
@rdebusscher
Copy link

Hi @deratzmann

Can you indicate what would be the use case for using skipdsfailure on Payara Micro? Is the datasource defined within the war file and thus not found during deployment?

With Payara Micro, the classic scenario is to define the datasource in a post boot command file as described in the documentation https://docs.payara.fish/community/docs/5.2020.2/documentation/payara-micro/asadmin/pre-and-post-boot-scripts.html.

Deployment from within Payara Micro is not using the asadmin deploy command and thus the skipdsfailure is not available.

Regards
Rudy

@OndroMih
Copy link
Contributor

Hi @deratzmann,

Can you please explain how you would use this feature? In Payara Micro, the connections to the DB are created during app deployment and it doesn't make sense that the DB isn't up and running at that time. However, if you really need it, you can do what you want if you deploy an application using the asadmin deploy command in a post boot command file (https://docs.payara.fish/community/docs/5.2020.3/documentation/payara-micro/asadmin/pre-and-post-boot-scripts.html).

We're likely to close this issue if you don't explain why this is a useful feature.

@OndroMih OndroMih added the Status: Abandoned User has not supplied reproducers for bug report, soon to be closed if user doesn’t come back label Aug 10, 2020
@khasunuma
Copy link

Hi @deratzmann, since no reproducer was provided and we weren't able to reproduce this issue, I'm going to close it. We'll reopen this issue if you provide us an easy to follow reproducer for the latest version of Payara. A reproducer should ideally follow the SSCCE rules: http://www.sscce.org/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Abandoned User has not supplied reproducers for bug report, soon to be closed if user doesn’t come back Status: Pending Waiting on the issue requester to give more details or share a reproducer
Projects
None yet
Development

No branches or pull requests

4 participants