PAYARA-1056 global thread pool statistics incorrect #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stored values. Also adds in copyright.
…s more responsive and accurate.
|
jenkins test please |
smillidge
reviewed
Oct 6, 2016
smillidge
approved these changes
Oct 6, 2016
|
jenkins test please |
|
One or more tests have failed |
|
jenkins test please |
|
All tests have passed |
Pandrex247
deleted the
PAYARA-1056-Global-Thread-pool-statistics-incorrect
branch
lprimak
pushed a commit
to flowlogix/Payara
that referenced
this pull request
Jul 5, 2017
* PAYARA-1056 Prevent < 0 values, and calculate global core and max thread count. * PAYARA-1056 Change the get methods to query the JVM rather than their stored values. Also adds in copyright. * PAYARA-1056 Remove whitespace edit * PAYARA-1056 Make the Global thread pool busy and current thread counts more responsive and accurate. * PAYARA-1056 Remove now redundant event monitoring methods, and other cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the global thread pool statistics much more complete, with it now counting the total maximum and minimum threads in all of the thread pools of a config.
It also edits the way the monitoring works so that it is more accurate by querying the JVM for the actual current number of threads, rather than relying upon events to alter internally stored values (which may have been missed or reset depending on when the monitor listener was registered).
Also renames the global thread pool stats from thread-pool to global-thread-pool-stats to make it more clear.