PAYARA-1926 Remove unnecessary validation for Mojarra #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGill98
reviewed
Oct 18, 2017
| * | ||
| * @return The name of the currently running application | ||
| */ | ||
| public String getName(); | ||
| String getName(); |
There was a problem hiding this comment.
Why has this been made package private?
There was a problem hiding this comment.
It's not package private, it's an interface and public is already the default ;)
There was a problem hiding this comment.
This is why I'm the apprentice ;)
| @Contract | ||
| public interface ResourceHandler { | ||
|
|
||
| public java.util.List getResourceList(); | ||
| public List getResourceList(); |
There was a problem hiding this comment.
That's made me feel a lot better ;)
Pandrex247
approved these changes
Oct 23, 2017
|
Jenkins, quick test Payara 5 please. |
|
Jenkins, quick test Payara 5 please |
|
Quick build and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAYARA-1926 Mojarra's default was set to false some time ago, but GF and now Payara wasn't updated it seems.