PAYARA-2109 Protect Admin Console Web Pages against Clickjacking/UI Redress attacks #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smillidge
requested changes
Oct 26, 2017
smillidge
requested changes
Oct 26, 2017
| @@ -300,6 +300,8 @@ http.XpoweredBy=XPowered By: | |||
| http.XpoweredByHelp=Include X-Powered-By: Servlet/3.0 in servlet-generated HTTP response headers | |||
| http.ServerHeader=Server Header: | |||
| http.ServerHeaderHelp=Include Server Header: Servlet/3.0 in servlet-generated HTTP response headers | |||
| http.XframeOptions=XFrame Options: | |||
| http.XframeOptionsHelp=Include X-Frame-Options: Servlet/3.0 in servlet-generated HTTP response headers | |||
There was a problem hiding this comment.
Probably should say "Default X-Frame-Options value to be included in all responses"
| httpHeader.getHeaders().removeHeader(Header.Server); | ||
| } | ||
|
|
||
| if (xFrameOptions == null && httpHeader.containsHeader(xFrameOptionsHeader)){ |
There was a problem hiding this comment.
I don't think you should remove an XFrameOptions Header if it is already present. XPoweredBy and Server are removed when configured to be removed because they leak security information. However XFrame-Options could be set by the application developer for legitimate reasons so should be honoured if present.
|
Jenkins test please |
|
Quick build and test passed! |
smillidge
approved these changes
Nov 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.