Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2511 Ensure Optional property is returned as empty and not as unconfigured value #2420

Merged
merged 1 commit into from Feb 18, 2018
Merged

PAYARA-2511 Ensure Optional property is returned as empty and not as unconfigured value #2420

merged 1 commit into from Feb 18, 2018

Conversation

smillidge
Copy link
Contributor

Fix to Microprofile Config api to ensure the optional is injected as empty if no value is specified for the property

@Inject
@ConfigProperty(name="test")
Optional<String> value;

@smillidge smillidge added this to the Payara 4.x milestone Feb 18, 2018
@smillidge
Copy link
Contributor Author

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@arjantijms arjantijms self-requested a review February 18, 2018 20:49
@arjantijms arjantijms merged commit 32f07aa into payara:master Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Payara 4.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smillidge @payara-ci @arjantijms @fturizo