Revert "PAYARA-2267 JPA Conversion now unwraps connection properly" #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cousjava
suggested changes
Mar 5, 2018
|
I am going to write a test which tests this.. stay tuned |
lprimak
approved these changes
Mar 5, 2018
|
jenkins test |
|
Quick build and test failed! |
|
jenkins test payara 4 |
|
After a debugging session, I realized that this particular getConnection() is not the same as the API and is expecting to return the unwrapped object |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2279
@smillidge @lprimak Please continue any discussion here - the PR had to merged to keep things moving.