Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2578 CDI roles Extension on Payara 4 doesn't have Arjan's rework #2523

Merged
merged 5 commits into from Mar 28, 2018
Merged

PAYARA-2578 CDI roles Extension on Payara 4 doesn't have Arjan's rework #2523

merged 5 commits into from Mar 28, 2018

Conversation

MeroRai
Copy link
Member

@MeroRai MeroRai commented Mar 13, 2018

No description provided.

arjantijms and others added 2 commits March 12, 2018 11:06
@arjantijms @MeroRai
PAYARA-2534 CDI roles - fixed several issues, specifically extension …
be4fcd7 
…not found one (payara#2478)

* PAYARA-2534 Fixed several issues, specifically extension not found one

* PAYARA-2534 Added copyright header
@MeroRai
Replaced lamda code
c38a96f
@MeroRai MeroRai requested a review from arjantijms March 13, 2018 12:26
@MeroRai MeroRai self-assigned this Mar 13, 2018
@MeroRai MeroRai added this to the Payara 4.x milestone Mar 13, 2018
@payara payara deleted a comment from payara-ci Mar 15, 2018
@payara payara deleted a comment from payara-ci Mar 15, 2018
@MeroRai
Copy link
Member Author

MeroRai commented Mar 15, 2018

Jenkins, quick test Payara 4 please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@Pandrex247
Copy link
Member

Jenkins, quick test Payara 4 JDK7 please

@payara-ci
Copy link
Contributor

Quick build and test failed!

@Pandrex247
Copy link
Member

Jenkins, quick test Payara 4 JDK7 please

@payara-ci
Copy link
Contributor

Quick build and test failed!

Pandrex247
Pandrex247 previously requested changes Mar 22, 2018
View reviewed changes
Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has JDK8 specific code in it, so either needs altering for JDK7, or removing from the JDK7 build via Maven profiles.

@MeroRai
Copy link
Member Author

MeroRai commented Mar 28, 2018

Jenkins, quick test Payara 4 JDK7 please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@arjantijms arjantijms merged commit b6ecbf8 into payara:Payara4 Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

@Pandrex247 Pandrex247 Pandrex247 left review comments

Assignees

@MeroRai MeroRai

Labels
None yet
Projects
None yet
Milestone
Payara 4.x
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MeroRai @payara-ci @Pandrex247 @arjantijms @smillidge @fturizo