PAYARA-2616-Align-javaee-api-dependency-versions-to-8.0 #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
|
Quick build and test failed! |
lprimak
approved these changes
Mar 18, 2018
|
Jenkins test please |
|
Quick build and test passed! |
arjantijms
suggested changes
Mar 22, 2018
nucleus/pom.xml
Outdated
| @@ -276,6 +276,7 @@ | |||
| <jackson.version>2.9.4</jackson.version> | |||
| <!-- A StAX implementation for JSON. --> | |||
|
|
|||
| <javaee.api.version>8.0</javaee.api.version> | |||
There was a problem hiding this comment.
Would be more clear to move this up a few lines so its directly underneath the "java ee" comment. (here: https://github.com/mulderbaba/Payara/blob/aad23d0ba3fe09dec8f726c46c446b2d2c323244/nucleus/pom.xml#L221)
arjantijms
approved these changes
Mar 22, 2018
smillidge
approved these changes
Mar 25, 2018
mulderbaba
force-pushed
the
PAYARA-2616-Align-javaee-api-dependency-versions-to-8.0
branch
from
08273be
to
251cbb9
Compare
|
Jenkins test please |
|
Quick build and test passed! |
…-compiler-version-1.8 moved javaee.api property def under its comment
|
Jenkins test please |
|
Quick build and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.